chore: upgrade to `protocol` v0.14.0 by igamigo · Pull Request #1891 · 0xMiden/miden-client

igamigo · 2026-03-11T20:03:38Z

This PR upgrades protocol to v0.14.

TODO:

Add proper description with most notable changes
Review changes to see that they comprehensively make sense (we went from protocol version next to 0.14.0-beta.1 to 0.14.0-rc.1 to 0.14.0 quite quickly so a bunch of things accumulated)

The beta API now takes supported_types as the second argument instead of using builder methods with_supports_all_types() / with_supported_type().

greenhat · 2026-03-24T13:27:52Z

Please update the miden-protocol and miden-standard deps to the version used in 0xMiden/node#1784.

igamigo · 2026-03-24T16:59:26Z

Please update the miden-protocol and miden-standard deps to the version used in 0xMiden/node#1784.

Currently happening here: #1928
I will pull the update commits here but I'm having trouble adapting some code (though this is mostly solved right now).

EDIT: Now merged back to this branch, Rust integration tests are working but WebClient ones still are not all the way there yet.

Bring all non-RPC-retry changes (RC bump, integration tests, web-client updates, CLI fixes, etc.) into the base branch so the PR diff only shows the RPC retry feature.

greenhat · 2026-03-25T09:05:14Z

0xMiden/node#1784 is merged and the branch is deleted. Please update the node deps. Thank you!

greenhat · 2026-03-30T12:29:06Z

I see errors when trying to compile the miden-client from this branch. I suspect the next branch of the node repo referenced in the dependencies for the node crates has "run away."

Build log:

   Compiling miden-client v0.14.0 (https://github.com/0xMiden/miden-client?branch=release%2Fv0.14.0-beta#6efc8ce6)
error[E0609]: no field `note_id` on type `NoteSyncRecord`
   --> /Users/green/.cargo/git/checkouts/miden-client-4cc430396025a571/6efc8ce/crates/rust-client/src/rpc/domain/note.rs:156:18
    |
156 |                 .note_id
    |                  ^^^^^^^ unknown field
    |
    = note: available fields are: `metadata_header`, `inclusion_proof`

error[E0609]: no field `inclusion_path` on type `NoteSyncRecord`
   --> /Users/green/.cargo/git/checkouts/miden-client-4cc430396025a571/6efc8ce/crates/rust-client/src/rpc/domain/note.rs:161:18
    |
161 |                 .inclusion_path
    |                  ^^^^^^^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
161 -                 .inclusion_path
161 +                 .inclusion_proof
    |

error[E0609]: no field `metadata` on type `NoteSyncRecord`
   --> /Users/green/.cargo/git/checkouts/miden-client-4cc430396025a571/6efc8ce/crates/rust-client/src/rpc/domain/note.rs:168:18
    |
168 |                 .metadata
    |                  ^^^^^^^^ unknown field
    |
    = note: available fields are: `metadata_header`, `inclusion_proof`

error[E0609]: no field `note_index_in_block` on type `NoteSyncRecord`
   --> /Users/green/.cargo/git/checkouts/miden-client-4cc430396025a571/6efc8ce/crates/rust-client/src/rpc/domain/note.rs:174:36
    |
174 |                 u16::try_from(note.note_index_in_block).map_err(|_| {
    |                                    ^^^^^^^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `metadata_header`, `inclusion_proof`

error[E0609]: no field `note_id` on type `NoteSyncRecord`
   --> /Users/green/.cargo/git/checkouts/miden-client-4cc430396025a571/6efc8ce/crates/rust-client/src/rpc/domain/transaction.rs:209:14
    |
209 |             .note_id
    |              ^^^^^^^ unknown field
    |
    = note: available fields are: `metadata_header`, `inclusion_proof`

error[E0609]: no field `metadata` on type `NoteSyncRecord`
   --> /Users/green/.cargo/git/checkouts/miden-client-4cc430396025a571/6efc8ce/crates/rust-client/src/rpc/domain/transaction.rs:217:14
    |
217 |             .metadata
    |              ^^^^^^^^ unknown field
    |
    = note: available fields are: `metadata_header`, `inclusion_proof`

For more information about this error, try `rustc --explain E0609`.
error: could not compile `miden-client` (lib) due to 6 previous errors

mmagician · 2026-03-30T13:14:16Z

@greenhat I think this might be due to not respecting the Cargo.lock file - are you building this branch directly by checking out the codebase, or referencing it as a dependency (in the latter case it won't respect Cargo.lock IIUC)

greenhat · 2026-03-30T13:47:18Z

@greenhat I think this might be due to not respecting the Cargo.lock file - are you building this branch directly by checking out the codebase, or referencing it as a dependency (in the latter case it won't respect Cargo.lock IIUC)

I think so. I use it as a dependency. Can we use ref instead of branch here for the node crates?

igamigo · 2026-03-30T14:31:47Z

@greenhat I think this might be due to not respecting the Cargo.lock file - are you building this branch directly by checking out the codebase, or referencing it as a dependency (in the latter case it won't respect Cargo.lock IIUC)

I think so. I use it as a dependency. Can we use ref instead of branch here for the node crates?

The node protobuf definitions changed in the last node commit or so. I've moved the Cargo.toml to rev references to make this more explicit for now and avoid that problem (I think patching just the miden-node-proto-build crate would have unblocked you as well, just for future reference).

juan518munoz

Looks like lots tests have been flagged as .slow(), and other to needed to sync up to a certain height had it increased (example1, example2, example3).

juan518munoz · 2026-03-30T14:14:15Z

.config/nextest.toml

+[test-groups.integration]
+max-threads = 5
+
+[[profile.default.overrides]]
+filter           = "package(miden-client-unit-tests)"
+threads-required = 2
+
+[[profile.default.overrides]]
+filter     = "binary(integration)"
+test-group = "integration"


Is this part of the realease or an optional optimization?

juan518munoz · 2026-03-30T14:15:03Z

.github/workflows/test.yml

+        shard_index: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+        shard_total: [10]


Same as comment above

juan518munoz · 2026-03-30T14:20:38Z

Makefile

 	cd ./crates/web-client && yarn run test:clean -- --project=chromium $(SHARD_PARAMETER)

+.PHONY: integration-test-web-client-opt
+integration-test-web-client-opt: ## Run integration tests for the web client with optimized wasm build (chromium)


Should we add a CI job for this? Or update the existing one

juan518munoz · 2026-03-30T15:22:44Z

crates/web-client/test/import_export.test.ts

+    });

-    await importDb(dbDump, page);
+    await clearStore(page, exported.storeName);


Strange that we are replacing a store import for a deletion

feat: upgrade protocol to v0.14.0-beta

ba88a6c

igamigo force-pushed the release/v0.14.0-beta branch from bd473a1 to ba88a6c Compare March 12, 2026 03:07

igamigo added 5 commits March 12, 2026 00:14

chore: remove unnecessary comment

91f6627

chore: lints

50da906

chore: update to latest node branch commit

b99b5bc

Merge branch 'next' into release/v0.14.0-beta

732866c

fix: update AccountComponentMetadata::new() calls in CLI build.rs

5fb7be3

The beta API now takes supported_types as the second argument instead of using builder methods with_supports_all_types() / with_supported_type().

igamigo force-pushed the release/v0.14.0-beta branch from ba2d82c to 5fb7be3 Compare March 12, 2026 15:13

igamigo added 2 commits March 12, 2026 12:23

chore: lints

06ca560

chore: bump cargo version so that accept header checks do not fail

c29ec0e

igamigo marked this pull request as ready for review March 12, 2026 15:59

igamigo added 5 commits March 12, 2026 15:03

chore: fixes

d950229

chore: patch

dcb822b

chore: cargo update

75341be

chore: clippy nightly

dd3db14

chore: clippy nightly

f96ebbe

greenhat mentioned this pull request Mar 16, 2026

Migrate to VM v0.22 and protocol v0.14 0xMiden/compiler#995

Merged

2 tasks

igamigo and others added 4 commits March 16, 2026 15:55

chore: mergebump vrsions

b644a12

chore: bump beta deps

879dbd2

chore: lints

9fad4f9

test: fix

3477c50

igamigo added 3 commits March 24, 2026 14:37

chore: pull non-RPC changes from igamigo-rpc-retry branch

35985bf

Bring all non-RPC-retry changes (RC bump, integration tests, web-client updates, CLI fixes, etc.) into the base branch so the PR diff only shows the RPC retry feature.

feat: retry RPC calls if on cooldown (#1928)

0260ba0

chore: skip test with fixme

b1d6e2a

igamigo changed the title ~~chore: upgrade protocol to beta~~ chore: upgrade to protocol v0.14.0 Mar 25, 2026

feat: protocol v0.14.0

b6d7992

chore: reference node's next

07333c8

igamigo added 5 commits March 25, 2026 11:40

chore: version setting

3357681

chore: small cleanups

2fe75ce

chore: small cleanups

2c33a90

chore: rename outputnote for webclient

99d84f2

chore: lints

8407b4e

igamigo added the blocked Something prevents working on this label Mar 25, 2026

This comment was marked as outdated.

Sign in to view

igamigo added 8 commits March 25, 2026 19:35

chore: lints and typedoc

695e163

Merge branch 'next' into release/v0.14.0-beta

c4041c3

refactor: align output note types

064b0b6

tests: fix tests

0e81840

chore: merge next

0773f77

chore: postmerge fixers

d458021

chore: typedoc

97795ec

chore: lints

e913db4

igamigo removed the blocked Something prevents working on this label Mar 30, 2026

test: re-add test changes

6efc8ce

igamigo added 2 commits March 30, 2026 10:58

fix: asset vault key serialization

00504f0

chore: move to rev

6ccf66a

juan518munoz reviewed Mar 30, 2026

View reviewed changes

igamigo added 4 commits March 30, 2026 12:49

chore: move some tests to remote prover job

1cb25d1

chore: simplify tests

c5f53af

chore: attempt to reduce codegen tiime

888b0ac

chore: run more optimized tests

4cb43d5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to `protocol` v0.14.0#1891

chore: upgrade to `protocol` v0.14.0#1891
igamigo wants to merge 42 commits intonextfrom
release/v0.14.0-beta

igamigo commented Mar 11, 2026 •

edited

Loading

Uh oh!

greenhat commented Mar 24, 2026

Uh oh!

igamigo commented Mar 24, 2026 •

edited

Loading

Uh oh!

greenhat commented Mar 25, 2026

Uh oh!

This comment was marked as outdated.

greenhat commented Mar 30, 2026

Uh oh!

mmagician commented Mar 30, 2026

Uh oh!

greenhat commented Mar 30, 2026

Uh oh!

igamigo commented Mar 30, 2026

Uh oh!

juan518munoz left a comment

Uh oh!

juan518munoz Mar 30, 2026

Uh oh!

juan518munoz Mar 30, 2026

Uh oh!

juan518munoz Mar 30, 2026

Uh oh!

juan518munoz Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		shard_index: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
		shard_total: [10]

Conversation

igamigo commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greenhat commented Mar 24, 2026

Uh oh!

igamigo commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greenhat commented Mar 25, 2026

Uh oh!

This comment was marked as outdated.

greenhat commented Mar 30, 2026

Uh oh!

mmagician commented Mar 30, 2026

Uh oh!

greenhat commented Mar 30, 2026

Uh oh!

igamigo commented Mar 30, 2026

Uh oh!

juan518munoz left a comment

Choose a reason for hiding this comment

Uh oh!

juan518munoz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

juan518munoz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

juan518munoz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

juan518munoz Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

igamigo commented Mar 11, 2026 •

edited

Loading

igamigo commented Mar 24, 2026 •

edited

Loading